Use old behavior for telegram webhook #31588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
This was referenced Jul 8, 2024
Merged
wxiaoguang
force-pushed
the
fix-webhook-tg
branch
from
4c8aefe
to
611c1d1
Compare
pull-request-size
bot
added
size/M
wxiaoguang
force-pushed
the
fix-webhook-tg
branch
from
611c1d1
to
6e46bbd
Compare
Merged
POPSuL
reviewed
Jul 8, 2024
| @@ -181,7 +182,7 @@ func (t telegramConvertor) Package(p *api.PackagePayload) (TelegramPayload, erro | |||
|
|
|||
| func createTelegramPayload(message string) TelegramPayload { | |||
| return TelegramPayload{ | |||
| Message: strings.TrimSpace(message), | |||
| Message: markup.Sanitize(strings.TrimSpace(message)), | |||
There was a problem hiding this comment.
Maybe html.EscapeString() for each fields (author, commit message) is better than santize of final message?
This santizer will not process the commit messages properly... Like that
git commit -am 'Implemented some <a href="https://im.hacker">feature</a>'
There was a problem hiding this comment.
That's the old behavior (I do not want to break too much in 1.22)
The complete fix is in Refactor webhook #31587 , it does what you suggested.
delvh
approved these changes
Jul 8, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Jul 9, 2024
GiteaBot
added
lgtm/done
wxiaoguang
added a commit
that referenced
this pull request
Jul 10, 2024
A more complete fix for #31588 1. Make "generic" code more readable 2. Clarify HTML or Markdown for the payload content
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31182 (only a quick fix, not quite right)