Fix: Allow org team names of length 255 in create team form (#31564) #31603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#31564) Gitea 1.22.1 was supposed to allow for team names of length 255 (up from 30) after the following PR was merged in: go-gitea#31410. However, the length of team names was still limited to 30 as described in this issue: go-gitea#31554. One more change to _gitea_ needs to be made to allow for the longer team names, as there is a 30 character limit here: https://github.com/go-gitea/gitea/blob/2c92c7c5226e29636a1d47a277130f477fa2037b/services/forms/org.go#L65 This PR changes that value to 255.
GiteaBot
added
modifies/go
pull-request-size
bot
added
the
size/XS
lunny
approved these changes
Jul 10, 2024
GiteaBot
added
lgtm/need 1
a1012112796
approved these changes
Jul 10, 2024
GiteaBot
added
lgtm/done
denyskon
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #31564 by @tobiasbp
Gitea 1.22.1 was supposed to allow for team names of length 255 (up from 30) after the following PR was merged in: #31410. However, the length of team names was still limited to 30 as described in this issue: #31554.
One more change to gitea needs to be made to allow for the longer team names, as there is a 30 character limit here:
gitea/services/forms/org.go
Line 65 in 2c92c7c
This PR changes that value to 255.