Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loadRepository error when access user dashboard #31719

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Jul 29, 2024

Fix a bug from #30156
image

Reproduce:
Ensure you have repos with actions, then access user dashboard, you will see this error.

ps: the commit statuses in user dashboard will be initialed no matter the repo has actions or not.
So commit statuses maybe empty, we need to skip them.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 29, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 29, 2024
@yp05327 yp05327 requested a review from Zettat123 July 29, 2024 02:33
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jul 29, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 29, 2024
@lunny lunny enabled auto-merge (squash) July 29, 2024 06:22
@lunny lunny merged commit 7b38863 into go-gitea:main Jul 29, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jul 29, 2024
@badhezi
Copy link

badhezi commented Jul 29, 2024

@Zettat123
FYI this does not resolve #30156 (comment) for me

@yp05327 yp05327 deleted the fix-loadrepoerror branch July 30, 2024 00:42
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 30, 2024
* giteaofficial/main:
  Set owner id to zero when GetRegistrationToken for repo (go-gitea#31725)
  fix(api): owner ID should be zero when created repo secret (go-gitea#31715)
  Fix API endpoint for registration-token (go-gitea#31722)
  Fix loadRepository error when access user dashboard (go-gitea#31719)
  Add permission check when creating PR (go-gitea#31033)
lunny pushed a commit that referenced this pull request Jul 30, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants