Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve get feed with pagination #31821

Merged
merged 18 commits into from
Sep 2, 2024
Merged

Improve get feed with pagination #31821

merged 18 commits into from
Sep 2, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 12, 2024

@lunny lunny added the performance/speed performance issues with slow downs label Aug 12, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 12, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 12, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 12, 2024
@lunny lunny mentioned this pull request Aug 12, 2024
Closed
delvh
delvh reviewed Aug 12, 2024
View reviewed changes
models/activities/action.go Show resolved Hide resolved
models/activities/action.go Outdated Show resolved Hide resolved
models/activities/action.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 14, 2024
delvh
delvh reviewed Aug 24, 2024
View reviewed changes
models/activities/action.go Show resolved Hide resolved
models/activities/action.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 26, 2024
@wolfogre wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 26, 2024
@wolfogre wolfogre removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 26, 2024
@wolfogre
Copy link
Member

Sorry, I added the label mistakenly, please ignore.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 26, 2024
yp05327
yp05327 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@yp05327 yp05327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#31821 (comment)

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 2, 2024
@lunny lunny added this to the 1.23.0 milestone Sep 2, 2024
@lunny lunny enabled auto-merge (squash) September 2, 2024 18:52
@lunny lunny merged commit 85b1f30 into go-gitea:main Sep 2, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 2, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 5, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6dce37d 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Remove html tags from create tag and branch translation (go-gitea#31973)
  Replace v-html with v-text in search inputbox (go-gitea#31966)
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Improve get feed with pagination (go-gitea#31821)
  Remove urls from translations (go-gitea#31950)
  Prevent update pull refs manually and will not affect other refs update (go-gitea#31931)
  [skip ci] Updated translations via Crowdin
  nix wording nit in todo code comment
  Fix 500 error when `state` params is set when editing issue/PR by API (go-gitea#31880)
  Fix sort order for organization home and user profile page (go-gitea#31921)
  Improve textarea paste (go-gitea#31948)
  Fix index too many file names bug (go-gitea#31903)
  [skip ci] Updated translations via Crowdin
  Move web globals to `web_src/js/globals.d.ts` (go-gitea#31943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@somera somera somera left review comments

@wolfogre wolfogre wolfogre approved these changes

@yp05327 yp05327 yp05327 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code performance/speed performance issues with slow downs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Feature Request for better performance on paging and lees memory usage on database
6 participants
@lunny @wolfogre @somera @yp05327 @delvh @GiteaBot