Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sort order for organization home and user profile page (#31921) #31922

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Fix sort order for organization home and user profile page (#31921) #31922

merged 2 commits into from
Sep 2, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Aug 26, 2024

Backport #31921

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 26, 2024
@GiteaBot GiteaBot added this to the 1.22.2 milestone Aug 26, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 26, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 26, 2024
@yp05327 yp05327 mentioned this pull request Aug 26, 2024
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 29, 2024
@silverwind
Copy link
Member

Wait on review for #31921?

@yp05327
Copy link
Contributor Author

yp05327 commented Aug 31, 2024

not related to it.

@lunny
Copy link
Member

lunny commented Sep 1, 2024

Please update to follow #31921 and also the comment should be changed #31921 (comment)

@yp05327
Copy link
Contributor Author

yp05327 commented Sep 1, 2024 •
edited
Loading

The solution is not the same to #31921. We can only add the missing options in v1.22

And the comment is also not related.
image

@yp05327 yp05327 mentioned this pull request Sep 1, 2024
Merged
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 2, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 2, 2024
@lunny lunny enabled auto-merge (squash) September 2, 2024 07:20
@lunny lunny merged commit cc15202 into go-gitea:release/v1.22 Sep 2, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 2, 2024
@yp05327 yp05327 deleted the backport-31921 branch September 24, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.2
Development

Successfully merging this pull request may close these issues.
4 participants
@yp05327 @silverwind @lunny @GiteaBot