Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace v-html with v-text in search inputbox (#31966) #31972

Closed
wants to merge 1 commit into from
Closed

Replace v-html with v-text in search inputbox (#31966) #31972

wants to merge 1 commit into from

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Sep 4, 2024

Backport #31966 by @lunny

Credit for @techknowlogick

@GiteaBot GiteaBot added modifies/js topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug labels Sep 4, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 4, 2024
@GiteaBot GiteaBot added this to the 1.22.2 milestone Sep 4, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 4, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 4, 2024
wxiaoguang
wxiaoguang previously requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WRONG

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 4, 2024
@wxiaoguang wxiaoguang dismissed their stale review September 4, 2024 04:11

dismiss for coming changes.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Sep 4, 2024
@lunny lunny mentioned this pull request Sep 4, 2024
Merged
@lunny lunny closed this Sep 4, 2024
@lunny lunny removed this from the 1.22.2 milestone Sep 4, 2024
@techknowlogick techknowlogick deleted the backport-31966-v1.22 branch September 4, 2024 08:01
lunny added a commit that referenced this pull request Sep 5, 2024
@lunny
Replace v-html with v-text in search inputbox (#31966) (#31973) (#31975)
244fb11 
Backport #31966, #31973
Cherry-pick 30da734,
74b1c58
Replace #31972

---------

Co-authored-by: techknowlogick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang left review comments

@sillyguodong sillyguodong Awaiting requested review from sillyguodong

@wolfogre wolfogre Awaiting requested review from wolfogre

Assignees

@lunny lunny

Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/js size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GiteaBot @lunny @wxiaoguang