Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update drone test intsructions in CONTRIBUTING.md #4055

Merged
merged 4 commits into from
May 27, 2018
Merged

Update drone test intsructions in CONTRIBUTING.md #4055

merged 4 commits into from
May 27, 2018

Conversation

techknowlogick
Copy link
Member

Fix #4053
Fix #3977

Credits: @axifive

@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation type/testing labels May 27, 2018
@codecov-io
Copy link

codecov-io commented May 27, 2018 •
edited
Loading

Codecov Report

Merging #4055 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4055   +/-   ##
=======================================
  Coverage   19.96%   19.96%           
=======================================
  Files         153      153           
  Lines       30478    30478           
=======================================
  Hits         6086     6086           
  Misses      23479    23479           
  Partials      913      913

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5095dfa...4f3eade. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 27, 2018
@lunny
Copy link
Member

lunny commented May 27, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 27, 2018
@lunny lunny added this to the 1.5.0 milestone May 27, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 27, 2018
@techknowlogick techknowlogick merged commit b660450 into go-gitea:master May 27, 2018
@techknowlogick techknowlogick deleted the techknowlogick-patch-1 branch May 27, 2018 17:01
This was referenced Mar 5, 2019
Closed
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation type/testing
Projects
None yet
Milestone
1.5.0
5 participants
@techknowlogick @codecov-io @lunny @lafriks @bkcsoft