-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for search by uid #4876
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkcsoft
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Sep 5, 2018
zeripath
force-pushed
the
search-by-uid
branch
3 times, most recently
from
September 5, 2018 21:28
ee6a892
to
d866399
Compare
Codecov Report
@@ Coverage Diff @@
## master #4876 +/- ##
==========================================
- Coverage 37.4% 37.38% -0.02%
==========================================
Files 306 306
Lines 45389 45397 +8
==========================================
- Hits 16978 16972 -6
- Misses 25956 25967 +11
- Partials 2455 2458 +3
Continue to review full report at Codecov.
|
lunny
approved these changes
Sep 7, 2018
bkcsoft
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Sep 7, 2018
zeripath
force-pushed
the
search-by-uid
branch
from
September 7, 2018 09:29
d866399
to
e3c1512
Compare
lafriks
approved these changes
Sep 9, 2018
bkcsoft
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Sep 9, 2018
zeripath
force-pushed
the
search-by-uid
branch
3 times, most recently
from
September 16, 2018 19:29
b65da14
to
7bf8856
Compare
appleboy
approved these changes
Sep 17, 2018
zeripath
force-pushed
the
search-by-uid
branch
2 times, most recently
from
September 20, 2018 19:47
92df673
to
cdcfed7
Compare
tonivj5
approved these changes
Sep 21, 2018
zeripath
force-pushed
the
search-by-uid
branch
2 times, most recently
from
September 25, 2018 16:57
f3aaa0d
to
f7e00cf
Compare
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
force-pushed
the
search-by-uid
branch
from
September 29, 2018 13:55
f7e00cf
to
2c355e1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/api
This PR adds API routes or modifies them
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment there is no way to search for users by their ID using the API. Gitlab does this by overloading the /users/{username} API routes to allow searching with user ID. Rather than go that route this pull request adds a uid parameter to the /users/search API and allows searching by user ID.