Fix SQL quoting #5117
Merged
Fix SQL quoting #5117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`show` is keyword in MySQL and has to be quoted to reference a column name. Use grave accents (ASCII code 96) for quoting to match rest of the source code. It's non-standard SQL, but it's supported by SQLite and MySQL. Signed-off-by: Filip Navara <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5117 +/- ##
======================================
Coverage 37.4% 37.4%
======================================
Files 308 308
Lines 45612 45612
======================================
Hits 17060 17060
Misses 26095 26095
Partials 2457 2457
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
|
But PostgreSQL nope, AFAIR. |
|
@er1z I assume it is handled somehow by the libraries because the rest of Gitea code base uses it too. Update: |
lafriks
approved these changes
Oct 20, 2018
bkcsoft
added
lgtm/need 1
jonasfranz
approved these changes
Oct 20, 2018
bkcsoft
added
lgtm/done
|
@filipnavara thanks for PR 😄 Please send backport of PR to release/v1.6 branch |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
showis keyword in MySQL and has to be quoted to reference a column name. Use grave accents (ASCII code 96) for quoting to match rest of the source code. It's non-standard SQL, but it's supported by SQLite and MySQL.Fixes #5106