Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitignore list #5258

Merged
merged 4 commits into from
Nov 3, 2018
Merged

Conversation

sapk
Copy link
Member

@sapk sapk commented Nov 2, 2018

fix #5257

The script https://github.com/go-gitea/gitea/blob/master/scripts/generate-gitignores.go need to be updated to handle link in the gitignore repo.

@codecov-io
Copy link

codecov-io commented Nov 2, 2018

Codecov Report

Merging #5258 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5258      +/-   ##
==========================================
+ Coverage   37.61%   37.62%   +<.01%     
==========================================
  Files         310      310              
  Lines       46042    46042              
==========================================
+ Hits        17320    17322       +2     
+ Misses      26243    26241       -2     
  Partials     2479     2479
Impacted Files Coverage Δ
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54259e2...4cce604. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 2, 2018
@techknowlogick techknowlogick added this to the 1.7.0 milestone Nov 2, 2018
@sapk sapk changed the title [WIP] Update gitignore list Update gitignore list Nov 2, 2018
@sapk
Copy link
Member Author

sapk commented Nov 2, 2018

This PR is ready for review.
I updated the script https://github.com/go-gitea/gitea/pull/5258/files#diff-fd99876caac1c11beb1c52ab37fb58f7 to copy content of symlink (Clojure, Fortran, Kotlin) in the source tar (to be sure to be compatible with windows).

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 3, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2018
@techknowlogick techknowlogick merged commit 57a8440 into go-gitea:master Nov 3, 2018
@sapk sapk deleted the updt-gitignore branch November 3, 2018 23:44
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clojure .gitignore file is not created properly.
5 participants