Add raw blob endpoint to get objects by SHA ID #5334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it possible to download raw blobs directly from /:repo/:username/raw/blob/:sha1 URLs.
* As an SHA-ID is no path getRefNameFromPath can't be used to verify file specifying parameter * added relevant change in go-gitea/git #132 Signed-off-by: Berengar W. Lehr <[email protected]>
Can't update all vendors due to errors Signed-off-by: Berengar W. Lehr <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5334 +/- ##
=========================================
Coverage ? 37.39%
=========================================
Files ? 312
Lines ? 46436
Branches ? 0
=========================================
Hits ? 17367
Misses ? 26583
Partials ? 2486
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lafriks
added
type/feature
|
@HoffmannP could you add some tests? |
lunny
approved these changes
Nov 18, 2018
bkcsoft
added
lgtm/need 1
lafriks
approved these changes
Nov 18, 2018
bkcsoft
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add raw blob endpoint
Updating #4110, this PR enables fetching of raw SHA-ID'd objects via
/:repo/:username/raw/blob/:sha1It builds upon #132 (originally #121)
Signed-off-by: Berengar W. Lehr [email protected]