Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default less and css to new default name #54

Merged
merged 3 commits into from
Nov 4, 2016
Merged

Set default less and css to new default name #54

merged 3 commits into from
Nov 4, 2016

Conversation

joubertredrat
Copy link
Contributor

@joubertredrat joubertredrat commented Nov 3, 2016

Remove mentions to Gogs on js, css and less files, generated with lessc 2.7.1

@codecov-io
Copy link

codecov-io commented Nov 3, 2016

Current coverage is 2.18% (diff: 100%)

Merging #54 into master will not change coverage

@@            master       #54   diff @@
========================================
  Files           31        31          
  Lines         7508      7508          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           164       164          
  Misses        7327      7327          
  Partials        17        17          

Powered by Codecov. Last update 03902bb...747f86a

@@ -31,23 +31,18 @@ pre.wrap,
code.wrap {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated changes for that PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But there are css changes, you just renamed the less file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tboerger was my fault, If you see on PR gogs/gogs#3786, don't have empty lines on css, I don't know why, my npm display that less version is 2.7.1, but on my terminal was using 1.4.2. Now I solved this and generated correct css files, with no empty files and with !important as defined on less.

@tboerger
Copy link
Member

tboerger commented Nov 3, 2016

One minor change, otherwise LGTM after rebase.

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 3, 2016
@tboerger tboerger added this to the 1.0.0 milestone Nov 3, 2016
@tboerger
Copy link
Member

tboerger commented Nov 3, 2016

LGTM

@DblK
Copy link
Member

DblK commented Nov 3, 2016

LGTM, Just need a rebase

@tboerger tboerger added the topic/ui Change the appearance of the Gitea UI label Nov 3, 2016
@joubertredrat
Copy link
Contributor Author

Done, with rebase

@joubertredrat
Copy link
Contributor Author

LGTM

@tboerger
Copy link
Member

tboerger commented Nov 4, 2016

LGTM

2 similar comments
@lunny
Copy link
Member

lunny commented Nov 4, 2016

LGTM

@xinity
Copy link
Contributor

xinity commented Nov 4, 2016

LGTM

@tboerger tboerger merged commit a46efe2 into go-gitea:master Nov 4, 2016
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants