Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git-Trees API #5403

Merged
merged 10 commits into from
Nov 28, 2018
Merged

Git-Trees API #5403

merged 10 commits into from
Nov 28, 2018

Conversation

Kasi-R
Copy link
Contributor

@Kasi-R Kasi-R commented Nov 26, 2018 •
edited
Loading

I somehow managed to butcher the PR at #4185

This is an updated PR with a couple changes.

  1. correct git route. (/trees -> /git/trees)
  2. additional commenting.
  3. Changed the types used as per Add repo trees go-sdk#94 (GitTreeEntry -> GitEntry) - superficial naming changes only.

Edit: Requires the PR at go-gitea/git#123

@techknowlogick techknowlogick added the modifies/api This PR adds API routes or modifies them label Nov 26, 2018
@lunny lunny added this to the 1.7.0 milestone Nov 26, 2018
@lunny
Copy link
Member

lunny commented Nov 26, 2018

should fix #1978

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 26, 2018
@lunny lunny mentioned this pull request Nov 26, 2018
Closed
@lafriks
Copy link
Member

lafriks commented Nov 26, 2018

go-gitea/git#123 merged, please update dep

lunny
lunny previously requested changes Nov 26, 2018
View reviewed changes
routers/api/v1/api.go Outdated Show resolved Hide resolved
adelowo
adelowo reviewed Nov 26, 2018
View reviewed changes
Copy link
Member

@adelowo adelowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick ... but a lot of variable definitions here seem to use Pascal case instead of camel case as the rest of the project

lafriks
lafriks requested changes Nov 26, 2018
View reviewed changes
routers/api/v1/repo/tree.go Outdated Show resolved Hide resolved
techknowlogick
techknowlogick requested changes Nov 27, 2018
View reviewed changes
routers/api/v1/repo/tree.go Show resolved Hide resolved
routers/api/v1/repo/tree.go Show resolved Hide resolved
@techknowlogick techknowlogick added the type/changelog Adds the changelog for a new Gitea version label Nov 27, 2018
@codecov-io
Copy link

codecov-io commented Nov 28, 2018 •
edited
Loading

Codecov Report

Merging #5403 into master will decrease coverage by 0.04%.
The diff coverage is 1.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5403      +/-   ##
==========================================
- Coverage   37.59%   37.54%   -0.05%     
==========================================
  Files         315      316       +1     
  Lines       46714    46783      +69     
==========================================
+ Hits        17561    17564       +3     
- Misses      26657    26723      +66     
  Partials     2496     2496
Impacted Files Coverage Δ
routers/api/v1/repo/tree.go 0% <0%> (ø)
routers/api/v1/api.go 73.4% <100%> (+0.05%) ⬆️
models/repo_list.go 64.55% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f17524b...29560ff. Read the comment docs.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2018
@techknowlogick
Copy link
Member

@lunny @lafriks please update review

lafriks
lafriks requested changes Nov 28, 2018
View reviewed changes
routers/api/v1/api.go Outdated Show resolved Hide resolved
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2018
@techknowlogick techknowlogick dismissed lunny’s stale review November 28, 2018 21:16

Unrelated route removed from this PR

@techknowlogick techknowlogick merged commit d5d847e into go-gitea:master Nov 28, 2018
@kolaente kolaente mentioned this pull request Jan 24, 2019
Merged
@richmahn
Copy link
Contributor

@Kasi-R Were there any API docs added for this, or plans to be added? https://try.gitea.io/api/v1/swagger doesn't show anything for git/trees

@sapk
Copy link
Member

sapk commented Jan 24, 2019

The docs seems to be missing in this PR and are done in a separate one #5834

@richmahn richmahn mentioned this pull request Jan 25, 2019
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adelowo adelowo adelowo left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
10 participants
@Kasi-R @lunny @lafriks @codecov-io @techknowlogick @richmahn @sapk @adelowo @bkcsoft @delvh