Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure .git/info is created before generating .git/info/sparse-che… #5825

Merged
merged 3 commits into from
Jan 24, 2019

Conversation

typeless
Copy link
Contributor

Under certain circumstances, .git/info might not exist.
Create it before generating .git/info/sparse-checkout.

Fixes #5824

@typeless typeless mentioned this pull request Jan 24, 2019
7 tasks
@codecov-io
Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #5825 into master will decrease coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5825      +/-   ##
==========================================
- Coverage   37.88%   37.88%   -0.01%     
==========================================
  Files         328      328              
  Lines       48256    48260       +4     
==========================================
+ Hits        18281    18282       +1     
- Misses      27345    27347       +2     
- Partials     2630     2631       +1
Impacted Files Coverage Δ
models/pull.go 50.95% <40%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88aa70b...9958bde. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 24, 2019
@lafriks lafriks added this to the 1.8.0 milestone Jan 24, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 24, 2019
@lafriks lafriks merged commit ec31ee1 into go-gitea:master Jan 24, 2019
bmackinney pushed a commit to bmackinney/gitea that referenced this pull request Jan 27, 2019
go-gitea#5825)

* Make sure .git/info is created before generating .git/info/sparse-checkout

* fix permissions
@typeless typeless deleted the fix-miss-git-info-dir branch April 3, 2019 04:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to merge pull request
5 participants