Makefile changes for Windows and easier development

[jolheiser]

This just adds your go/bin to PATH and changes generate-stylesheets to use npx which is bundled with npm version 5.2+
If npx isn't found, it asks the user to update their npm to version 5.2+

This makes it easier for Windows devs, since Windows didn't like node_modules/.bin/lessc etc complaining about the path separator.
As well, it covers if a user hasn't already added their go/bin to their PATH, which would then make things like lint and misspell-check not work.

[jolheiser]

@silverwind Any suggestions or things you don't like/would change?

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@eea1155). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6103   +/-   ##
=========================================
  Coverage          ?   38.86%           
=========================================
  Files             ?      352           
  Lines             ?    50045           
  Branches          ?        0           
=========================================
  Hits              ?    19450           
  Misses            ?    27780           
  Partials          ?     2815

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea1155...99ff335. Read the comment docs.

[silverwind]

If you remove node_modules/.bin it will use the global binaries instead of the ones we depend on. I suggest instead do npx lessc and similar. It will require node.js >= 8, but seeing as 6 is going EOL in 2 months, it should be acceptable.

[jolheiser]

Ah, okay. I had first tried that, but npx didn't seem to play nice with me. Any tips?

To clarify, npx lessc didn't seem to work, it wanted npx less.
And I never did get postcss to work for me.

[silverwind]

Never tried it on Windows, but I assume it should just work. Tried updating node and/or npm?

[jolheiser]

Using the current LTS of Node. Did a full reinstall for testing.
I'll mess with it a little more tonight and see what I can come up with.

On a separate note, since the local node modules is first in the path wouldn't it use that?

[silverwind]

Would probably work, not sure if $PATH can really work properly with relative paths. npx uses node_modules and falls back to downloading the module if not found.

[jolheiser]

@silverwind Alright, it's using npx now. Turns out my npm path was messed up for some reason and that messed with npx

@zeripath I also changed to using $(go env GOPATH) to add to the path

@techknowlogick Pinging you as well since you had brought it up in the Discord. 👍

[zeripath]

Oh before we merge this @jolheiser could you check the hacking documentation to make sure it doesn't conflict with this?

I think it's fine and if anything we suggest doing stuff that this makes unnecessary but just to be sure...

[jolheiser]

The hacking documentation recommends adding Go to your path, which is unnecessary with this change, however as you said that's not necessarily a bad thing. This would just double it up.

As for the npx changes, currently the hacking documentation says to run npm install but doesn't actually mention that the user will need node (which would also contain npm).
The changes would check for npx and alert the user to update to a compatible version of npm, though.

Should I add a comment about installing node/npm before working with the stylesheets?

[silverwind]

Should I add a comment about installing node/npm before working with the stylesheets?

Yes, I'd recommend we require Node.js >= 8.0 with npm included (to my knowledge, all distributions of Node.js include npm).

[jolheiser]

Done

[silverwind]

Would you mind also adding the version here?

[jolheiser]

Done

[jolheiser]

@zeripath I think this is ready now.