Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ParsePatch function to work with quoted diff --git strings #6323

Merged
merged 3 commits into from
Mar 14, 2019
Merged

Fix ParsePatch function to work with quoted diff --git strings #6323

merged 3 commits into from
Mar 14, 2019

Commits on Mar 14, 2019

  1. Fix ParsePatch to work properly with quoted diff --git string 

    Currently ParsePatch fails when a diff contains a quoted diff line like:

diff --git "a/file" "b/file"

This patch makes it properly parse the line when that happens.

Fixes go-gitea#6309
    @mrsdizzie
    mrsdizzie committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    7b0fb3a View commit details
    Browse the repository at this point in the history

  2. Add test for regular case while here

    @mrsdizzie
    mrsdizzie committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    5f432ff View commit details
    Browse the repository at this point in the history

  3. Simplify string modification

    @mrsdizzie
    mrsdizzie committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    5b7961d View commit details
    Browse the repository at this point in the history