Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move code.gitea.io/git to code.gitea.io/gitea/modules/git #6364

Merged
merged 21 commits into from
Mar 27, 2019
Merged

move code.gitea.io/git to code.gitea.io/gitea/modules/git #6364

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3f12c75
move code.gitea.io/git to code.gitea.io/gitea/modules/git
lunny Mar 19, 2019
f22a9d3
fix imports
lunny Mar 19, 2019
a0f3655
fix fmt
lunny Mar 20, 2019
f79fd61
fix misspell
lunny Mar 20, 2019
c845653
remove wrong tests data
lunny Mar 20, 2019
9c7466a
fix unit tests
lunny Mar 21, 2019
80b25c4
fix tests
lunny Mar 22, 2019
fe694d0
fix tests
lunny Mar 25, 2019
0db2e30
fix tests
lunny Mar 25, 2019
109af59
fix tests
lunny Mar 26, 2019
6e9bc6f
fix tests
lunny Mar 26, 2019
9483b9d
enable Debug to trace the failure tests
lunny Mar 26, 2019
3e038cd
fix tests
lunny Mar 26, 2019
1abe8c2
fix tests
lunny Mar 26, 2019
aa01681
fix tests
lunny Mar 26, 2019
5b5db53
fix tests
lunny Mar 26, 2019
26b0dcc
fix tests
lunny Mar 26, 2019
e120e7f
comment commit count tests since git clone depth is 50
lunny Mar 26, 2019
c42efe0
fix tests
lunny Mar 27, 2019
bc5e46c
update from code.gitea.io/git
lunny Mar 27, 2019
707b69d
revert change to makefile
lunny Mar 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions modules/git/hook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,20 @@ func (h *Hook) Name() string {
func (h *Hook) Update() error {
if len(strings.TrimSpace(h.Content)) == 0 {
if isExist(h.path) {
return os.Remove(h.path)
err := os.Remove(h.path)
if err != nil {
return err
}
}
h.IsActive = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not move this above the ifExist?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just update the current codes on github.com/go-gitea/git.

return nil
}
return ioutil.WriteFile(h.path, []byte(strings.Replace(h.Content, "\r", "", -1)), os.ModePerm)
err := ioutil.WriteFile(h.path, []byte(strings.Replace(h.Content, "\r", "", -1)), os.ModePerm)
if err != nil {
return err
}
h.IsActive = true
return nil
}

// ListHooks returns a list of Git hooks of given repository.
Expand Down