Change order that PostProcess Processors are run #6445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure Processors that work on full links are run first so that something matching another pattern doesn't alter a link before we get to it, for example: https://stackoverflow.com/questions/2896191/what-is-go-used-fore Fixes go-gitea#4813
techknowlogick
approved these changes
Mar 27, 2019
GiteaBot
added
the
lgtm/need 1
|
@mrsdizzie Can you run |
jolheiser
approved these changes
Mar 27, 2019
GiteaBot
added
lgtm/done
|
ugh sorry dunno how I missed that, fixed! |
Codecov Report
@@ Coverage Diff @@
## master #6445 +/- ##
=========================================
- Coverage 39.4% 39.4% -0.01%
=========================================
Files 393 393
Lines 53264 53264
=========================================
- Hits 20990 20989 -1
- Misses 29287 29290 +3
+ Partials 2987 2985 -2
Continue to review full report at Codecov.
|
|
@mrsdizzie it's ok, happens to all of us. Thanks for the PR 😄 Please backport to release/v1.8 branch. @jolheiser Is working on the RC2 changelog and so we probably can get this change in. |
mrsdizzie
added a commit
to mrsdizzie/gitea
that referenced
this pull request
Mar 27, 2019
Make sure Processors that work on full links are run first so that something matching another pattern doesn't alter a link before we get to it, for example: https://stackoverflow.com/questions/2896191/what-is-go-used-fore Fixes go-gitea#4813
techknowlogick
added
the
backport/done
techknowlogick
pushed a commit
that referenced
this pull request
Mar 27, 2019
Make sure Processors that work on full links are run first so that something matching another pattern doesn't alter a link before we get to it, for example: https://stackoverflow.com/questions/2896191/what-is-go-used-fore Fixes #4813
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure Processors that work on full links are run first so that
something matching another pattern doesn't alter a link before we get to
it, for example:
https://stackoverflow.com/questions/2896191/what-is-go-used-fore
Fixes #4813