Properly escape release attachment URL #6512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure file attachments on a release get a properly escaped URL when linking. Fixes go-gitea#6506
zeripath
approved these changes
Apr 5, 2019
GiteaBot
added
the
lgtm/need 1
zeripath
added
backport/done
lafriks
approved these changes
Apr 5, 2019
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #6512 +/- ##
==========================================
+ Coverage 40.26% 40.26% +<.01%
==========================================
Files 403 403
Lines 54069 54069
==========================================
+ Hits 21770 21772 +2
+ Misses 29282 29280 -2
Partials 3017 3017
Continue to review full report at Codecov.
|
|
@mrsdizzie merged. Please backport :) |
mrsdizzie
added a commit
to mrsdizzie/gitea
that referenced
this pull request
Apr 5, 2019
Make sure file attachments on a release get a properly escaped URL when linking. Fixes go-gitea#6506
techknowlogick
added
the
backport/done
techknowlogick
pushed a commit
that referenced
this pull request
Apr 5, 2019
6543
added a commit
to 6543-forks/gitea
that referenced
this pull request
Dec 28, 2019
* before only first got downloaded - now each is downloadable * dos also take care of go-gitea#6506 (fix was: go-gitea#6512)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure file attachments on a release get a properly escaped URL when
linking.
Fixes #6506