Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable refresh token invalidation #6584

Merged
merged 5 commits into from
Apr 12, 2019
Merged

Add option to disable refresh token invalidation #6584

merged 5 commits into from
Apr 12, 2019

Conversation

jonasfranz
Copy link
Member

Disables refresh token invalidation by default (as option) to fix concurrency problems with drone.

Blocks harness/harness#2622

@codecov-io
Copy link

codecov-io commented Apr 12, 2019 •
edited
Loading

Codecov Report

Merging #6584 into master will increase coverage by 0.03%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6584      +/-   ##
=========================================
+ Coverage   40.46%   40.5%   +0.03%     
=========================================
  Files         405     405              
  Lines       54350   54351       +1     
=========================================
+ Hits        21994   22013      +19     
+ Misses      29332   29311      -21     
- Partials     3024    3027       +3
Impacted Files Coverage Δ
modules/auth/user_form.go 42.85% <ø> (ø) ⬆️
modules/setting/setting.go 48.16% <ø> (ø) ⬆️
routers/user/oauth.go 44% <28.57%> (+5.11%) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️
models/oauth2_application.go 56.04% <0%> (+1.2%) ⬆️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff0a12...7b6dc70. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 12, 2019
@jonasfranz jonasfranz marked this pull request as ready for review April 12, 2019 06:49
@jonasfranz jonasfranz changed the title WIP: Add option to disable refresh token invalidation Add option to disable refresh token invalidation Apr 12, 2019
@jonasfranz jonasfranz added this to the 1.8.0 milestone Apr 12, 2019
@jonasfranz jonasfranz added the type/enhancement An improvement of existing functionality label Apr 12, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 12, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 12, 2019
@lunny lunny merged commit 783cd64 into go-gitea:master Apr 12, 2019
@jonasfranz jonasfranz deleted the feature/disable-refresh-token-invalidation branch April 12, 2019 08:25
@jonasfranz jonasfranz mentioned this pull request Apr 12, 2019
Merged
@lunny
Copy link
Member

lunny commented Apr 12, 2019

@jonasfranz please send a back port to release/v1.8

@lunny lunny modified the milestones: 1.8.0, 1.9.0 Apr 12, 2019
jonasfranz added a commit to jonasfranz/gitea that referenced this pull request Apr 12, 2019
@jonasfranz
Add option to disable refresh token invalidation (go-gitea#6584)
bc0aa0e 
* Add option to disable refresh token invalidation

Signed-off-by: Jonas Franz <[email protected]>

* Add integration tests and remove wrong todos

Signed-off-by: Jonas Franz <[email protected]>

* Fix typo

Signed-off-by: Jonas Franz <[email protected]>

* Fix tests and add documentation

Signed-off-by: Jonas Franz <[email protected]>

(cherry picked from commit 783cd64)
Signed-off-by: Jonas Franz <[email protected]>
@jonasfranz jonasfranz mentioned this pull request Apr 12, 2019
Merged
@jonasfranz
Copy link
Member Author

@lunny Backport done: #6587

lafriks pushed a commit that referenced this pull request Apr 12, 2019
@jonasfranz @lafriks
Add option to disable refresh token invalidation (#6584) (#6587)
72f4cdf 
* Add option to disable refresh token invalidation

Signed-off-by: Jonas Franz <[email protected]>

* Add integration tests and remove wrong todos

Signed-off-by: Jonas Franz <[email protected]>

* Fix typo

Signed-off-by: Jonas Franz <[email protected]>

* Fix tests and add documentation

Signed-off-by: Jonas Franz <[email protected]>

(cherry picked from commit 783cd64)
Signed-off-by: Jonas Franz <[email protected]>
@jonasfranz jonasfranz added backport/done All backports for this PR have been created backport/v1.8 labels Apr 12, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolaente kolaente kolaente approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jonasfranz @codecov-io @lunny @zeripath @kolaente @GiteaBot