Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to convert mysql database from utf8 to utf8mb4 #7144

Merged
merged 10 commits into from
Jun 8, 2019
Merged

Add command to convert mysql database from utf8 to utf8mb4 #7144

merged 10 commits into from
Jun 8, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 6, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 6, 2019 •
edited
Loading

Codecov Report

Merging #7144 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7144      +/-   ##
==========================================
- Coverage   41.63%   41.62%   -0.01%     
==========================================
  Files         447      448       +1     
  Lines       60888    60902      +14     
==========================================
+ Hits        25351    25353       +2     
- Misses      32248    32260      +12     
  Partials     3289     3289
Impacted Files Coverage Δ
models/convert.go 0% <0%> (ø)
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb31a5...9feaa70. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 6, 2019
zeripath
zeripath approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I would say that users should really do this themselves I guess it's just about complex enough that for ease of use we can provide this.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 6, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 6, 2019
@BetaCat0
Copy link
Member

BetaCat0 commented Jun 6, 2019

Agree with @zeripath

jolheiser
jolheiser reviewed Jun 6, 2019
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small sprinkling of wording/typo nits.
This will be a nice convenience, thanks for making it! 😃

cmd/convert.go Outdated Show resolved Hide resolved
cmd/convert.go Outdated Show resolved Hide resolved
cmd/convert.go Outdated Show resolved Hide resolved
cmd/convert.go Outdated Show resolved Hide resolved
cmd/convert.go Outdated Show resolved Hide resolved
models/convert.go Outdated Show resolved Hide resolved
models/convert.go Outdated Show resolved Hide resolved
@techknowlogick techknowlogick added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jun 7, 2019
lunny and others added 7 commits June 8, 2019 15:33
@lunny @jolheiser
Update cmd/convert.go
034dbcc 
Co-Authored-By: John Olheiser <[email protected]>
@lunny @jolheiser
Update cmd/convert.go
8da5d79 
Co-Authored-By: John Olheiser <[email protected]>
@lunny @jolheiser
Update cmd/convert.go
9246c82 
Co-Authored-By: John Olheiser <[email protected]>
@lunny @jolheiser
Update models/convert.go
d683e72 
Co-Authored-By: John Olheiser <[email protected]>
@lunny @jolheiser
Update models/convert.go
f1b9b1c 
Co-Authored-By: John Olheiser <[email protected]>
@lunny @jolheiser
Update cmd/convert.go
c684acd 
Co-Authored-By: John Olheiser <[email protected]>
@lunny @jolheiser
Update cmd/convert.go
62d324d 
Co-Authored-By: John Olheiser <[email protected]>
@lunny
Copy link
Member Author

lunny commented Jun 8, 2019

@jolheiser Thanks, done.

@lunny lunny merged commit 23a2ee3 into go-gitea:master Jun 8, 2019
@lunny lunny added this to the 1.9.0 milestone Jun 8, 2019
@lunny lunny deleted the lunny/convert_mysqlmb4 branch June 10, 2019 11:49
@zeripath zeripath mentioned this pull request Jun 22, 2019
Closed
7 tasks
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jolheiser @jeffliu27
Add command to convert mysql database from utf8 to utf8mb4 (go-gitea#…
57bd64b 
…7144)

* add command to convert mysql database from utf8 to utf8mb4

* Update cmd/convert.go

Co-Authored-By: John Olheiser <[email protected]>

* Update cmd/convert.go

Co-Authored-By: John Olheiser <[email protected]>

* Update cmd/convert.go

Co-Authored-By: John Olheiser <[email protected]>

* Update models/convert.go

Co-Authored-By: John Olheiser <[email protected]>

* Update models/convert.go

Co-Authored-By: John Olheiser <[email protected]>

* Update cmd/convert.go

Co-Authored-By: John Olheiser <[email protected]>

* Update cmd/convert.go

Co-Authored-By: John Olheiser <[email protected]>
@immanuelfodor immanuelfodor mentioned this pull request Jul 31, 2019
Closed
2 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser left review comments

@BetaCat0 BetaCat0 BetaCat0 approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lunny @codecov-io @BetaCat0 @zeripath @jolheiser @techknowlogick @GiteaBot