Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always set userID on LFS authentication #7224

Merged
merged 3 commits into from
Jun 17, 2019
Merged

Always set userID on LFS authentication #7224

merged 3 commits into from
Jun 17, 2019

Conversation

zeripath
Copy link
Contributor

Fix #5478 on 1.8
Fix #7219 on 1.8

These issues are fixed on 1.9 through #6993 which is too major a change to backport to 1.8.

@zeripath
Copy link
Contributor Author

OK, the first commit could still lead to problems with getting LFS files from public repos using deploy keys that are not associated with this deploy key.

I think deploy keys should only be used to read repositories that they are associated with, not just any repository - and in fact #6993 did this.

The second commit in this PR replicates this change of semantics.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 16, 2019
@zeripath zeripath added this to the 1.8.3 milestone Jun 16, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 17, 2019
@zeripath zeripath mentioned this pull request Jun 17, 2019
Closed
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2019
@lafriks lafriks merged commit 5d1a8d2 into go-gitea:release/v1.8 Jun 17, 2019
@zeripath zeripath deleted the fix-5478-7219-on-1.8 branch June 17, 2019 15:46
@zeripath zeripath mentioned this pull request Jun 18, 2019
Closed
7 tasks
@gabyx gabyx mentioned this pull request Sep 26, 2019
Closed
7 tasks
@gabyx
Copy link

gabyx commented Sep 26, 2019

It would be nice if, any reviewer who reviewed this ticket, could draw the attention to #8273.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.8.3
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @gabyx @lunny @lafriks @GiteaBot