Revert RenderCommitMessageLink part of #7659 #7923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary-kim
changed the title
RenderCommitMessageLink may have the potential for issues and is overall not very intuitive for the user in its current state. This commit will revert the usage of RenderCommitMessageLink that was added in go-gitea#7659 to work on addressing some of those issues to and merge this feature again in a more polished state. Signed-off-by: Gary Kim <[email protected]>
gary-kim
force-pushed
the
revert/7659/render-commit-message-link
branch
from
67f4e7e
to
1e54280
Compare
lunny
approved these changes
Aug 20, 2019
GiteaBot
added
the
lgtm/need 1
mrsdizzie
approved these changes
Aug 20, 2019
GiteaBot
added
lgtm/done
lafriks
approved these changes
Aug 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #7923 +/- ##
=========================================
Coverage ? 41.42%
=========================================
Files ? 478
Lines ? 63945
Branches ? 0
=========================================
Hits ? 26491
Misses ? 34003
Partials ? 3451Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the request of @lafriks
RenderCommitMessageLink may have the
potential for issues and is overall
not very intuitive for the user in its
current state.
This commit will revert the usage
of RenderCommitMessageLink that was
added in #7659 to work on addressing
some of those issues to and merge this
feature again in a more polished state.
We can also use this PR to discuss a bit as to what the potential issues of
RenderCommitMessageLinkare and possible solutions.