Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsBranchExist: return false if provided name is empty #8485

Merged
merged 4 commits into from
Oct 13, 2019
Merged

IsBranchExist: return false if provided name is empty #8485

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afdb597
IsBranchExist: return false if provided name is empty
zeripath Oct 13, 2019
9f7e5e9
Ensure that the reference returned is actually of a valid type
zeripath Oct 13, 2019
1cb3cbc
Merge branch 'master' into fix-8482-IsBranchExist-should-return-false…
techknowlogick Oct 13, 2019
7ae507d
Merge branch 'master' into fix-8482-IsBranchExist-should-return-false…
lunny Oct 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions modules/git/repo_branch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,14 @@ func IsBranchExist(repoPath, name string) bool {

// IsBranchExist returns true if given branch exists in current repository.
func (repo *Repository) IsBranchExist(name string) bool {
_, err := repo.gogitRepo.Reference(plumbing.ReferenceName(BranchPrefix+name), true)
return err == nil
if name == "" {
return false
}
reference, err := repo.gogitRepo.Reference(plumbing.ReferenceName(BranchPrefix+name), true)
if err != nil {
return false
}
return reference.Type() != plumbing.InvalidReference
}

// Branch represents a Git branch.
Expand Down