fixes #8725: change footer from © Gitea to Powered by Gitea
#8735
Conversation
|
close #8725 |
GiteaBot
added
the
lgtm/need 2
|
To show that the copyright notice is related to the product and not the content it could say something like |
Just Powered by is enaugh imho |
|
Yes, I also think that © is not need. |
|
@alexanderadam can you move |
|
@guillep2k but we should put the copyright information on some page on a former production. Maybe we could make a page on admin panel to display the copyright and other information. |
|
@lunny I don't think it's needed as all copyright info is in source code |
|
@lafriks As I know, not everyone will see your copyright on codes. Many of them just download binary and use it. It's a binary or production not a service, so I think it's necessary and maybe we also need to add contributors there. |
Sure, but at the moment I'm not quite confident anymore that there is a consensus in this issue at all. 😉
Are you sure? That it's necessary? IMHO the copyright note adds no value here because the legal declaration is more or less the license. So linking the license would probably indeed add a value (which is already done for the JS libaries anyway). Or maybe it would be good to have a general license page or so. But again: it would probably better to ask a proper lawyer regarding this instead everyone speculating here. 😉 |
I like that idea. "About Gitea" in the menu? 😁 (It could be only accessible for admin, but I'd make it accessible for all). |
|
@guillep2k -> GDPR for Europe ;) |
|
@6543 God Damn Pull Request? 😁 |
|
@6543 A GDPR should be provided by the service provider who running a gitea instance but not with the gitea binary. @guillep2k I like your idea, we could add an |
|
I'm in support of the idea of having the |
|
@alexanderadam Could you add an about page in this PR? |
It would be better if someone else could do this. |
|
Just a approve away from merge right? so many forgotten PRs 😄 |
| @@ -1,7 +1,7 @@ | |||
| <footer> | |||
| <div class="ui container"> | |||
| <div class="ui left"> | |||
| © Gitea {{if (or .ShowFooterVersion .PageIsAdmin)}}{{.i18n.Tr "version"}}: {{AppVer}}{{end}} {{if ShowFooterTemplateLoadTime}}{{.i18n.Tr "page"}}: <strong>{{LoadTimes .PageStartTime}}</strong> {{.i18n.Tr "template"}}: <strong>{{call .TmplLoadTimes}}</strong>{{end}} | |||
| Powered by Gitea {{if (or .ShowFooterVersion .PageIsAdmin)}}{{.i18n.Tr "version"}}: {{AppVer}}{{end}} {{if ShowFooterTemplateLoadTime}}{{.i18n.Tr "page"}}: <strong>{{LoadTimes .PageStartTime}}</strong> {{.i18n.Tr "template"}}: <strong>{{call .TmplLoadTimes}}</strong>{{end}} | |||
There was a problem hiding this comment.
Powered by should be translatable
There was a problem hiding this comment.
The whole string should be translatable, because there's no guaranteed word order for all languages (e.g. Japanese 「Giteaを搭載する」).
|
@alexanderadam what is the status of this? |
|
@alexanderadam do you need help? |
|
I think we should move this to 1.12.0 because @alexanderadam dont respond + this smal improvement block 1.11.0 |
|
I will fix it |
I like this proposal so I thought I just could make a PR for it.
I'm just not sure whether it should stay static or moved into the locale data.