Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move more webhook codes from models to webhook module #8802

Merged
merged 4 commits into from
Nov 3, 2019
Merged

Move more webhook codes from models to webhook module #8802

merged 4 commits into from
Nov 3, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 3, 2019

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 3, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 3, 2019
6543
6543 requested changes Nov 3, 2019
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"models/webhook_test.go:31:16: w.GetSlackHook undefined (type *Webhook has no field or method GetSlackHook)"

@6543

This comment has been minimized.

Sign in to view
@codecov-io
Copy link

Codecov Report

Merging #8802 into master will decrease coverage by 0.02%.
The diff coverage is 2.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8802      +/-   ##
==========================================
- Coverage   41.25%   41.22%   -0.03%     
==========================================
  Files         542      542              
  Lines       69708    69708              
==========================================
- Hits        28758    28738      -20     
- Misses      37269    37289      +20     
  Partials     3681     3681
Impacted Files Coverage Δ
models/webhook.go 70.46% <ø> (+3.23%) ⬆️
modules/webhook/dingtalk.go 0% <0%> (ø)
modules/webhook/discord.go 1.3% <0%> (ø)
modules/webhook/webhook.go 45.31% <0%> (ø) ⬆️
modules/webhook/telegram.go 0% <0%> (ø)
modules/webhook/msteams.go 0% <0%> (ø)
routers/api/v1/convert/convert.go 81.73% <0%> (ø) ⬆️
routers/api/v1/utils/hook.go 0% <0%> (ø) ⬆️
routers/repo/webhook.go 1.38% <0%> (ø) ⬆️
modules/webhook/slack.go 0.92% <15.78%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7a6d9...daa88e1. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2019
@zeripath
Copy link
Contributor

zeripath commented Nov 3, 2019

make lg-tm work

@zeripath zeripath merged commit a966a02 into go-gitea:master Nov 3, 2019
blueworrybear added a commit to blueworrybear/gitea that referenced this pull request Nov 14, 2019
@blueworrybear
update go-gitea#8671 move release tag created hook to modules/notific…
948cc25 
…ation/webhook due to go-gitea#8802 refactoring
techknowlogick pushed a commit that referenced this pull request Nov 22, 2019
@blueworrybear @techknowlogick
Send tag create and push webhook when release created on UI (#8671)
eb1b225 
* 'update'

* Send push tag event when release created

* send tag create event while release created in UI

* update to go v1.13

* fix gofmt error

* update #8671 move release tag created hook to modules/notification/webhook due to #8802 refactoring

* use NotifyCreateRef and NotifyPushCommits instead of NotifyNewReleaseTag

* move tag notification to correct place
lafriks pushed a commit to lafriks-fork/gitea that referenced this pull request Jan 13, 2020
@blueworrybear @lafriks
Send tag create and push webhook when release created on UI (go-gitea…
ed4ffe1 
…#8671)

* 'update'

* Send push tag event when release created

* send tag create event while release created in UI

* update to go v1.13

* fix gofmt error

* update go-gitea#8671 move release tag created hook to modules/notification/webhook due to go-gitea#8802 refactoring

* use NotifyCreateRef and NotifyPushCommits instead of NotifyNewReleaseTag

* move tag notification to correct place
zeripath pushed a commit that referenced this pull request Jan 13, 2020
@lafriks @blueworrybear @zeripath
Send tag create and push webhook when release created on UI (#8671) (#…
b67a023 
…9702)

* 'update'

* Send push tag event when release created

* send tag create event while release created in UI

* update to go v1.13

* fix gofmt error

* update #8671 move release tag created hook to modules/notification/webhook due to #8802 refactoring

* use NotifyCreateRef and NotifyPushCommits instead of NotifyNewReleaseTag

* move tag notification to correct place

Co-authored-by: Benno <[email protected]>
@lunny lunny deleted the lunny/move_webhook branch November 18, 2020 04:36
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @6543 @codecov-io @zeripath @guillep2k @GiteaBot