Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move less from public/ to web_src/ so that it will not be packed on binary #8908

Merged
merged 4 commits into from
Nov 12, 2019
Merged

Move less from public/ to web_src/ so that it will not be packed on binary #8908

merged 4 commits into from
Nov 12, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 10, 2019

Extract from #8598

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 10, 2019
@lunny lunny mentioned this pull request Nov 10, 2019
Merged
@codecov-io
Copy link

codecov-io commented Nov 11, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a0d4014). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8908   +/-   ##
=========================================
  Coverage          ?   41.26%           
=========================================
  Files             ?      547           
  Lines             ?    70764           
  Branches          ?        0           
=========================================
  Hits              ?    29199           
  Misses            ?    37846           
  Partials          ?     3719

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d4014...c4a5008. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 11, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 11, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 12, 2019
@sapk sapk merged commit e4e6d48 into go-gitea:master Nov 12, 2019
@lunny lunny deleted the lunny/move_less branch November 12, 2019 09:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @sapk @guillep2k @GiteaBot