Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Properly fix displaying virtual session provider in admin panel (#9137) #9203

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 29, 2019

Backports #9137

Although #7300 properly shadows the password from the virtual session
provider, the template displaying the provider config still presumed
that the config was JSON.

This PR updates the template and properly hides the Virtual Session
provider.

Fixes #7147

…itea#9137)

* Properly fix go-gitea#7127

Although go-gitea#7300 properly shadows the password from the virtual session
provider, the template displaying the provider config still presumed
that the config was JSON.

This PR updates the template and properly hides the Virtual Session
provider.

Fixes go-gitea#7127

* update per @silverwind's suggestion
@techknowlogick techknowlogick added this to the 1.10.1 milestone Nov 29, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 29, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2019
@techknowlogick techknowlogick merged commit f36efe0 into go-gitea:release/v1.10 Nov 29, 2019
@6543 6543 deleted the backports_9137 branch November 29, 2019 10:38
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants