Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] [API] Allow only specific Colums to be updated on Issue (#9539) #9580

Merged
merged 5 commits into from
Jan 2, 2020
Merged

[Backport] [API] Allow only specific Colums to be updated on Issue (#9539) #9580

merged 5 commits into from
Jan 2, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 1, 2020

backports #9539

@6543
Fix go-gitea#9189 - API Allow only specific Colums to be updated on I…
eb994a4 
…ssue (go-gitea#9539)

* dont insert "-1" in any case to issue.poster_id

* Make sure API cant override importand fields

* code format

* add Test for IssueEdit

* load milestone and return it on IssueEdit via API

* extend Test for TestAPIEditIssue
@6543
fix TEST
21187b2
@6543
Merge branch 'release/v1.10' into backports_9539
8b372fa
@lafriks lafriks added this to the 1.10.2 milestone Jan 2, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 2, 2020
lunny
lunny requested changes Jan 2, 2020
View reviewed changes
models/issue.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Jan 2, 2020

@lunny done + #9583

@lunny
Copy link
Member

lunny commented Jan 2, 2020

@6543 see my comment on #9580 (comment) , Why we need to move the loadPoster before neuterCrossReferences?

@6543
Copy link
Member Author

6543 commented Jan 2, 2020 •
edited
Loading

@lunny done

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 2, 2020
@6543
Copy link
Member Author

6543 commented Jan 2, 2020

ready to merge 🚀

@techknowlogick techknowlogick merged commit 17c691f into go-gitea:release/v1.10 Jan 2, 2020
@6543 6543 deleted the backports_9539 branch January 2, 2020 08:15
@6543 6543 mentioned this pull request Jan 2, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.10.2
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @lunny @lafriks @techknowlogick @GiteaBot