Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limiter: fix get username #226

Merged
merged 2 commits into from
Feb 3, 2023
Merged

limiter: fix get username #226

merged 2 commits into from
Feb 3, 2023

Conversation

msaf1980
Copy link
Collaborator

@msaf1980 msaf1980 commented Feb 3, 2023

  • Fix get username
  • Success limiter request metric

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 3, 2023
View reviewed changes
render/handler.go
@@ -278,7 +279,8 @@
targetsLen += len(targets.List)
}

qlimiter = data.GetQueryLimiter(username, h.config, &fetchRequests)
luser, qlimiter = data.GetQueryLimiter(username, h.config, &fetchRequests)
logger.Debug("use user limiter", zap.String("username", username), zap.String("luser", luser))

Check failure

Code scanning / CodeQL

Log entries created from user input

This log entry depends on a [user-provided value](1).
render/handler.go
@@ -278,7 +279,8 @@
targetsLen += len(targets.List)
}

qlimiter = data.GetQueryLimiter(username, h.config, &fetchRequests)
luser, qlimiter = data.GetQueryLimiter(username, h.config, &fetchRequests)
logger.Debug("use user limiter", zap.String("username", username), zap.String("luser", luser))

Check failure

Code scanning / CodeQL

Log entries created from user input

This log entry depends on a [user-provided value](1).
@msaf1980 msaf1980 merged commit a7f3018 into go-graphite:master Feb 3, 2023
@msaf1980 msaf1980 deleted the limiter branch February 7, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@msaf1980