Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGo-1.10.x support #12

Closed
sbinet opened this issue May 29, 2018 · 4 comments
Closed

CGo-1.10.x support #12

sbinet opened this issue May 29, 2018 · 4 comments
Assignees

Comments

@sbinet
Copy link
Member

sbinet commented May 29, 2018

Go-1.10.x fixed a possible arbitrary code execution:

this prevents croot to compile:

$> mk -v
github.com/go-hep/croot/cmem
github.com/go-hep/croot/cmd/gen-croot-dict
github.com/go-hep/croot/cgentype
github.com/go-hep/croot
go build github.com/go-hep/croot: invalid flag in #cgo LDFLAGS: -m64
make: *** [Makefile:13: install] Error 1
**error** running make -f Makefile: exit status 2
@sbinet sbinet self-assigned this May 29, 2018
@sbinet
Copy link
Member Author

sbinet commented May 29, 2018

@ebusato thanks for noticing :)

sbinet added a commit that referenced this issue May 29, 2018
@sbinet
Copy link
Member Author

sbinet commented May 29, 2018

@ebusato, could you try the issue-12 branch ?

@ebusato
Copy link

ebusato commented May 30, 2018 via email

@sbinet
Copy link
Member Author

sbinet commented May 30, 2018

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants