Skip to content

Commit

Permalink
[#145] fix to match AuthProvider interface
Browse files Browse the repository at this point in the history
  • Loading branch information
@coryb
coryb committed Feb 22, 2018
1 parent 20a9666 commit 80325a5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion session.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type AuthOptions struct {
Password string
}

func (a *AuthOptions) AuthParams() *jiradata.AuthParams {
func (a *AuthOptions) ProvideAuthParams() *jiradata.AuthParams {
return &jiradata.AuthParams{
Username: a.Username,
Password: a.Password,
Expand Down

2 comments on commit 80325a5

@djui
Copy link

@djui djui commented on 80325a5 Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can prevent this from happening again with a var _ AuthProvider = (*AuthOptions)(nil), for all of these interfaces.

@coryb
Copy link
Contributor Author

@coryb coryb commented on 80325a5 Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would make sense in a _test.go file.

Please sign in to comment.