Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CmdList is hardcoded to 500 results. #10

Closed
mikepea opened this issue Jul 31, 2015 · 0 comments · Fixed by #11
Closed

CmdList is hardcoded to 500 results. #10

mikepea opened this issue Jul 31, 2015 · 0 comments · Fixed by #11

Comments

@mikepea
Copy link
Collaborator

mikepea commented Jul 31, 2015

Noticed this whilst looking thru the commands.go

json, err := jsonEncode(map[string]interface{}{¬
     "jql":        query,
     "startAt":    "0",
     "maxResults": "500",
     "fields":     fields,
})

I know we have projects with more than this open, so it would be great to expose this as an option.

(NB: i plan to submit a PR for this!)
mikepea pushed a commit to mikepea/go-jira that referenced this issue Jul 31, 2015
Add --max_results option for 'ls'
e06ff0c 
This closes go-jira#10

Shifts the hardcoded maxResults value for the cmdList json body
into a 'max_results' option.

Note that testing against our JIRA instance, in a project with
more than 1000 open issues, suggests that the JIRA has an internal
limit of 1000 results in a single query.
@mikepea mikepea mentioned this issue Jul 31, 2015
Merged
@coryb coryb closed this as completed in #11 Jul 31, 2015
pdericson pushed a commit to pdericson/go-jira that referenced this issue Sep 14, 2017
Add --max_results option for 'ls'
43a2753 
This closes go-jira#10

Shifts the hardcoded maxResults value for the cmdList json body
into a 'max_results' option.

Note that testing against our JIRA instance, in a project with
more than 1000 open issues, suggests that the JIRA has an internal
limit of 1000 results in a single query.
@hkyeakley hkyeakley mentioned this issue Oct 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --max_results option for 'ls' mikepea/go-jira
1 participant
@mikepea