Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (possible) infinite loop from CmdLogin. #395

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

seanblong
Copy link
Contributor

Couldn't determine original intention of loop within CmdLogin, but ran into an issue locally where a cron job that ran the login command inadvertently got stuck in a failure loop where it continued to make bad requests to the Jira server.

@seanblong
Copy link
Contributor Author

I believe this also addresses the reported issue: #345

@georgettica
Copy link
Collaborator

yeah! this looks great!

please add me as a reviewer and I will approve

@seanblong seanblong marked this pull request as draft July 16, 2021 00:30
@seanblong seanblong marked this pull request as ready for review July 16, 2021 00:30
@catskul
Copy link
Contributor

catskul commented Nov 21, 2021

Any reason this isn't merged?

@georgettica
Copy link
Collaborator

georgettica commented Nov 21, 2021

Not really, just lost touch of the project.
Thanks for checking on it.

I'll take a second look and merge when done

@catskul
Copy link
Contributor

catskul commented Nov 21, 2021

Tested this one locally and appears to work correctly, and resolves loop as I saw it as well.

@georgettica
Copy link
Collaborator

seems I don't have the power yet to approve (although I am in the list?)

@catskul
Copy link
Contributor

catskul commented Nov 21, 2021

Thanks for attempting! maybe we can get @coryb, @ldelossa, or @mikepea to weigh in and/or give you merging rights.

@georgettica
Copy link
Collaborator

🤞

@catskul
Copy link
Contributor

catskul commented Nov 27, 2021

Got a response from @mikepea https://twitter.com/mikepea/status/1463942769097904128 though it seems he might not be comfortable approving new maitainers because he's not been involved for a while.

@georgettica
Copy link
Collaborator

Might be worth mentioning here that I was added to some extent as a maintainer
#426

@catskul
Copy link
Contributor

catskul commented Nov 29, 2021

@mikepea if you get a chance this week could you see if this one can be merged too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants