-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Templates Readable #473
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems OK to me and not functionality looks to be broken (only refactoring the template)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, use {{-
or -}}
to avoid the extra blank lines on all places you are expanding the template for better reading. Also, check for the sprig functions. I'm not sure if we have it, but we can also add it.
Co-authored-by: Alan Voiski <[email protected]>
Co-authored-by: Alan Voiski <[email protected]>
Co-authored-by: Alan Voiski <[email protected]>
Co-authored-by: Alan Voiski <[email protected]>
The templates in jiracli/templates.go have logic in them. Currently, it's difficult to grok what's going on in these templates because of the way they're written.
This change does not introduce new functionality; it just sweeps through this template file ensuring that the templates are readable.
With this change, it would be easier — in future — to update these template, or introduce new functionality to these templates.
Templates