Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation to auth with pass #91

Closed
wants to merge 1 commit into from

Conversation

kBite
Copy link

@kBite kBite commented Jul 14, 2017

Currently README.md is missing a crucial part: when I configure go-jira to use pass, which entry is it looking for? It's 'GoJira/'. Documentation to create this entry was added to README.md.

Currently README.md is missing a crucial part: when I configure go-jira
to use pass, which entry is it looking for? It's 'GoJira/<user>'.
@coryb
Copy link
Contributor

coryb commented Jul 14, 2017

Hey thanks, I am confused though. go-jira will insert the password to the pass store the first time it prompts you if it is missing: https://github.com/Netflix-Skunkworks/go-jira/blob/master/password.go#L65 So I am surprised to see that you thought it was required to manually register your password with pass. Did it not work for you that way?

@kBite
Copy link
Author

kBite commented Jul 17, 2017

No, it didn't. I can reproduce this:

# rm manually set pw
$ pass rm -r GoJira
$ jira fields
Jira Password [user]: ********
$ echo $?
0
$ pass show | grep -i GoJira; echo $?
1

Configration is correct as I can use go-jira with pass after manually adding my account to pass.

I never debugged go code, but maybe I can give you information to fix this.

EDIT: I curl'ed a request. I get:

...
X-Seraph-LoginReason: OK
...

Maybe https://github.com/Netflix-Skunkworks/go-jira/blob/master/commands.go#L50 does not match?

@coryb
Copy link
Contributor

coryb commented Jul 17, 2017

Interesting, thanks for the confirmation. That line section of code you indicate is just checking to see if the password-source has any value, if so it calls SetPass, so I would think it would work in your case. I will try to reproduce on my end and see if I can get to the bottom of it.
-Cory

@kBite
Copy link
Author

kBite commented Jul 19, 2017

An issue seems to me more appropriate to track this bug (#97).

@kBite kBite closed this Jul 19, 2017
@kBite kBite deleted the add-documentation-usage-pass branch July 19, 2017 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants