Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resolver/discovery): expose create watcher timeout error #3392

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

ThereWeGo
Copy link
Contributor

Description (what this PR does / why we need it):

使用etcd 服务发现, 当etcd leader 意外终止时, grpc resolver 将无法获取目标服务endpoint, 导致服务调用失败.
暴露这个错误可以使用户获得一定的兜底能力, 且不影响框架的功能及完整性.
用户更为无感的处理上述bug, 需要进一步修复.

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 12, 2024
@shenqidebaozi shenqidebaozi changed the title fix(resolver/discovery): expose create watcher timeout error feat(resolver/discovery): expose create watcher timeout error Aug 15, 2024
@dosubot dosubot bot added the LGTM label Aug 15, 2024
@shenqidebaozi shenqidebaozi merged commit 6427904 into go-kratos:main Aug 19, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants