fix: The random sample size is too small, which can easily cause unit… #3457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
harbourlga
force-pushed
the
fix-random-test
branch
from
65b8d2f
to
d50539c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3457 +/- ##
==========================================
- Coverage 84.12% 81.68% -2.44%
==========================================
Files 89 92 +3
Lines 4182 4325 +143
==========================================
+ Hits 3518 3533 +15
- Misses 471 601 +130
+ Partials 193 191 -2 ☔ View full report in Codecov by Sentry. |
… tests to fail. * lint: should omit type int from declaration of var randomNumber * lint: gofumpt
harbourlga
force-pushed
the
fix-random-test
branch
from
00ec74b
to
231cc8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… tests to fail.
Description (what this PR does / why we need it):
Increase the sample size of random and use percentages to judge the results
Which issue(s) this PR fixes (resolves / be part of):
Other special notes for the reviewers: