Skip to content

Commit

Permalink
Decode function extensions.
Browse files Browse the repository at this point in the history
  • Loading branch information
niemeyer committed May 2, 2016
1 parent ab44379 commit 29c1796
Show file tree
Hide file tree
Showing 4 changed files with 427 additions and 0 deletions.
256 changes: 256 additions & 0 deletions internal/json/decode.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ type decodeState struct {
nextscan scanner // for calls to nextValue
savedError error
useNumber bool
ext *Extension
}

// errPhase is used for errors that should not happen unless
Expand Down Expand Up @@ -369,6 +370,9 @@ func (d *decodeState) value(v reflect.Value) {

case scanBeginLiteral:
d.literal(v)

case scanBeginFunc:
d.function(v)
}
}

Expand Down Expand Up @@ -718,6 +722,213 @@ func (d *decodeState) object(v reflect.Value) {
}
}

// function consumes a function from d.data[d.off-1:], decoding into the value v.
// the first byte of the function name has been read already.
func (d *decodeState) function(v reflect.Value) {
// Check for unmarshaler.
u, ut, pv := d.indirect(v, false)
if u != nil {
d.off--
err := u.UnmarshalJSON(d.next())
if err != nil {
d.error(err)
}
return
}
if ut != nil {
d.saveError(&UnmarshalTypeError{"object", v.Type(), int64(d.off)})
d.off--
d.next() // skip over { } in input
return
}
v = pv

// Decoding into nil interface? Switch to non-reflect code.
if v.Kind() == reflect.Interface && v.NumMethod() == 0 {
v.Set(reflect.ValueOf(d.functionInterface()))
return
}

nameStart := d.off - 1

if op := d.scanWhile(scanContinue); op != scanFuncArg {
d.error(errPhase)
}

funcName := string(d.data[nameStart : d.off-1])
funcData := d.ext.funcs[funcName]
if funcData.key == "" {
d.error(fmt.Errorf("json: unknown function %s", funcName))
}

// Check type of target:
// struct or
// map[string]T or map[encoding.TextUnmarshaler]T
switch v.Kind() {
case reflect.Map:
// Map key must either have string kind or be an encoding.TextUnmarshaler.
t := v.Type()
if t.Key().Kind() != reflect.String &&
!reflect.PtrTo(t.Key()).Implements(textUnmarshalerType) {
d.saveError(&UnmarshalTypeError{"object", v.Type(), int64(d.off)})
d.off--
d.next() // skip over { } in input
return
}
if v.IsNil() {
v.Set(reflect.MakeMap(t))
}
case reflect.Struct:

default:
d.saveError(&UnmarshalTypeError{"object", v.Type(), int64(d.off)})
d.off--
d.next() // skip over { } in input
return
}

// TODO Fix case of func field as map.
//topv := v

// Figure out field corresponding to function.
key := []byte(funcData.key)
if v.Kind() == reflect.Map {
elemType := v.Type().Elem()
v = reflect.New(elemType).Elem()
} else {
var f *field
fields := cachedTypeFields(v.Type())
for i := range fields {
ff := &fields[i]
if bytes.Equal(ff.nameBytes, key) {
f = ff
break
}
if f == nil && ff.equalFold(ff.nameBytes, key) {
f = ff
}
}
if f != nil {
for _, i := range f.index {
if v.Kind() == reflect.Ptr {
if v.IsNil() {
v.Set(reflect.New(v.Type().Elem()))
}
v = v.Elem()
}
v = v.Field(i)
}
if v.Kind() == reflect.Ptr {
if v.IsNil() {
v.Set(reflect.New(v.Type().Elem()))
}
v = v.Elem()
}
}
}

var mapElem reflect.Value

// Parse function arguments.
for i := 0; ; i++ {
// closing ) - can only happen on first iteration.
op := d.scanWhile(scanSkipSpace)
if op == scanEndFunc {
break
}

// Back up so d.value can have the byte we just read.
d.off--
d.scan.undo(op)

if i >= len(funcData.args) {
d.error(fmt.Errorf("json: too many arguments for function %s", funcName))
}
key := []byte(funcData.args[i])

// Figure out field corresponding to key.
var subv reflect.Value
destring := false // whether the value is wrapped in a string to be decoded first

if v.Kind() == reflect.Map {
elemType := v.Type().Elem()
if !mapElem.IsValid() {
mapElem = reflect.New(elemType).Elem()
} else {
mapElem.Set(reflect.Zero(elemType))
}
subv = mapElem
} else {
var f *field
fields := cachedTypeFields(v.Type())
for i := range fields {
ff := &fields[i]
if bytes.Equal(ff.nameBytes, key) {
f = ff
break
}
if f == nil && ff.equalFold(ff.nameBytes, key) {
f = ff
}
}
if f != nil {
subv = v
destring = f.quoted
for _, i := range f.index {
if subv.Kind() == reflect.Ptr {
if subv.IsNil() {
subv.Set(reflect.New(subv.Type().Elem()))
}
subv = subv.Elem()
}
subv = subv.Field(i)
}
}
}

// Read value.
if destring {
switch qv := d.valueQuoted().(type) {
case nil:
d.literalStore(nullLiteral, subv, false)
case string:
d.literalStore([]byte(qv), subv, true)
default:
d.saveError(fmt.Errorf("json: invalid use of ,string struct tag, trying to unmarshal unquoted value into %v", subv.Type()))
}
} else {
d.value(subv)
}

// Write value back to map;
// if using struct, subv points into struct already.
if v.Kind() == reflect.Map {
kt := v.Type().Key()
var kv reflect.Value
switch {
case kt.Kind() == reflect.String:
kv = reflect.ValueOf(key).Convert(v.Type().Key())
case reflect.PtrTo(kt).Implements(textUnmarshalerType):
kv = reflect.New(v.Type().Key())
d.literalStore(key, kv, true)
kv = kv.Elem()
default:
panic("json: Unexpected key type") // should never occur
}
v.SetMapIndex(kv, subv)
}

// Next token must be , or ).
op = d.scanWhile(scanSkipSpace)
if op == scanEndFunc {
break
}
if op != scanFuncArg {
d.error(errPhase)
}
}
}

// literal consumes a literal from d.data[d.off-1:], decoding into the value v.
// The first byte of the literal has been read already
// (that's how the caller knows it's a literal).
Expand Down Expand Up @@ -933,6 +1144,8 @@ func (d *decodeState) valueInterface() interface{} {
return d.objectInterface()
case scanBeginLiteral:
return d.literalInterface()
case scanBeginFunc:
return d.functionInterface()
}
}

Expand Down Expand Up @@ -1047,6 +1260,49 @@ func (d *decodeState) literalInterface() interface{} {
}
}

// functionInterface is like function but returns map[string]interface{}.
func (d *decodeState) functionInterface() map[string]interface{} {
nameStart := d.off - 1

if op := d.scanWhile(scanContinue); op != scanFuncArg {
d.error(errPhase)
}

funcName := string(d.data[nameStart : d.off-1])
funcData := d.ext.funcs[funcName]
if funcData.key == "" {
d.error(fmt.Errorf("json: unknown function %s", funcName))
}

m := make(map[string]interface{})
for i := 0; ; i++ {
// Look ahead for ) - can only happen on first iteration.
op := d.scanWhile(scanSkipSpace)
if op == scanEndFunc {
break
}

// Back up so d.value can have the byte we just read.
d.off--
d.scan.undo(op)

if i >= len(funcData.args) {
d.error(fmt.Errorf("json: too many arguments for function %s", funcName))
}
m[funcData.args[i]] = d.valueInterface()

// Next token must be , or ).
op = d.scanWhile(scanSkipSpace)
if op == scanEndFunc {
break
}
if op != scanFuncArg {
d.error(errPhase)
}
}
return map[string]interface{}{funcData.key: m}
}

// getu4 decodes \uXXXX from the beginning of s, returning the hex value,
// or it returns -1.
func getu4(s []byte) rune {
Expand Down
36 changes: 36 additions & 0 deletions internal/json/extension.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package json

// Extension holds a set of additional rules to be used when unmarshaling
// strict JSON or JSON-like content.
type Extension struct {
funcs map[string]funcExt
keyed map[string]func() interface{}
}

type funcExt struct {
key string
args []string
}

// Extend changes the decoder behavior to consider the provided extension.
func (dec *Decoder) Extend(ext *Extension) { dec.d.ext = ext }

// Func defines a function call that may be observed inside JSON content.
// A function with the provided name will be unmarshaled as the document
// {key: {args[0]: ..., args[N]: ...}}.
func (e *Extension) Func(name string, key string, args ...string) {
if e.funcs == nil {
e.funcs = make(map[string]funcExt)
}
e.funcs[name] = funcExt{key, args}
}

// KeyedDoc defines a key that when observed as the first element inside a
// JSON document or sub-document triggers the parsing of that document as
// the value returned by the provided function.
func (e *Extension) KeyedDoc(key string, new func() interface{}) {
if e.keyed == nil {
e.keyed = make(map[string]func() interface{})
}
e.keyed[key] = new
}
Loading

0 comments on commit 29c1796

Please sign in to comment.