Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving "Validating unexported fields #417" #1234

Merged

Conversation

nikolaianohyn
Copy link
Contributor

Add supporting for validation private fields #417

@go-playground/validator-maintainers

@nikolaianohyn nikolaianohyn requested a review from a team as a code owner February 22, 2024 12:45
@coveralls
Copy link

coveralls commented Feb 22, 2024

Coverage Status

coverage: 74.208% (+0.04%) from 74.172%
when pulling 6292cff on nikolaianohyn:unexported_field_validation
into b328f72 on go-playground:master.

Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I still have to review carefully, new laptop still in the mail so be a bit, but due to the use of unsafe I will request that this needs to become an opt-in option when initializing validator and documentation can indicate that and that opting in accepts that risk.

@nikolaianohyn
Copy link
Contributor Author

@deankarn thanks for your proposal, it looks valid. Changes added.

@nikolaianohyn
Copy link
Contributor Author

@deankarn if I can speed up the review process, let me know.

Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I will add a little more to the opt-in function comment but code looks great!

@deankarn deankarn merged commit cec504f into go-playground:master Mar 2, 2024
12 checks passed
d1slike pushed a commit to txix-open/validator that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants