feat(#1291): upgrade mimetype dependency version for secure #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I looked into it a bit, the mimetype repo started using bytes.Cut with version 1.4.4. bytes.Cut came with version 1.18 of go. Check for details. Therefore, an error occurs in version 1.17. We can remove 1.17 from the supported versions. Since 1.17 is already available for older versions, this will not be a problem. |
|
Yes, what I wrote in my previous comment is no longer valid. We used the module replace feature, which is a better way. This way, we can continue to support 1.17. Now we just need to include this pr for security |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
the mimetype dependency version upgraded.
Check for details #1291
@go-playground/validator-maintainers