Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bcp 47 language tag validator #730

Merged
merged 2 commits into from
Apr 7, 2021
Merged

feat: add bcp 47 language tag validator #730

merged 2 commits into from
Apr 7, 2021

Conversation

joshuaslate
Copy link
Contributor

Fixes Or Enhances

This adds a new validator: language_tag, which uses x/language to parse a string to validate that it's a BCP 47 tag.

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/admins

@coveralls
Copy link

coveralls commented Feb 20, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 76.094% when pulling aaeabe8 on joshuaslate:feat/lang_tag_validator into f6584a4 on go-playground:master.

deankarn
deankarn reviewed Apr 6, 2021
View reviewed changes
baked_in.go Outdated Show resolved Hide resolved
@deankarn deankarn merged commit add373f into go-playground:master Apr 7, 2021
@joshuaslate joshuaslate deleted the feat/lang_tag_validator branch April 7, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn Awaiting requested review from deankarn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuaslate @coveralls @deankarn