Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including regex version (Semantic Versioning 2.0.0) validation #831

Merged
merged 2 commits into from
Jan 2, 2022

Conversation

jtseng-godaddy
Copy link
Contributor

@jtseng-godaddy jtseng-godaddy commented Sep 8, 2021

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@coveralls
Copy link

coveralls commented Sep 8, 2021

Coverage Status

Coverage increased (+0.01%) to 75.136% when pulling 6f7121f on jtseng-godaddy:master into 8fe074c on go-playground:master.

@jtseng-godaddy jtseng-godaddy changed the title Including regex version validation Including regex version (Semantic Versioning 2.0.0) validation Sep 8, 2021
@jtseng-godaddy
Copy link
Contributor Author

Please consider merging! Thank you @deankarn

deankarn
deankarn previously approved these changes Jan 2, 2022
Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deankarn deankarn dismissed stale reviews from rdreyer-godaddy and themself via 6f7121f January 2, 2022 01:36
@deankarn deankarn merged commit 06ec79d into go-playground:master Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants