Change noRetryError for temporary errors #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lavoiesl I like your proposal of using |
- Expose an `Unwrap` method to leverage go's standard unwrapping - Let the error escape, such that hooks and end-users can access the `Temporary` information. - Do not wrap if the error already exposes `Temporary`, to honour it.
hurracrane
force-pushed
the
seb-temp-error
branch
from
74e505c
to
d4c5d52
Compare
|
@lavoiesl please do not close, I will be merging this PR for v3 tonight. |
|
I will do resolve conflicts and merge. |
|
The PR was assigned to me and it has merge conflicts. |
|
Thanks, I will take care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unwrapmethod to leverage go's standard unwrappingTemporaryinformation.Temporary, to honour it.The main benefit is to leverage
net/*'s standard errors; most of them already exposeTemporarymethods.