Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing source files #108

Closed
gshields opened this issue Jul 11, 2020 · 10 comments
Closed

missing source files #108

gshields opened this issue Jul 11, 2020 · 10 comments
Labels
question Questions related to rod

Comments

@gshields
Copy link

windows 10 version 2004
go version go1.15beta1 windows/amd64

go get -u -fix github.com/go-rod/rod
cannot find package "github.com/pierrec/lz4/v3" in any of:
C:\go\src\github.com\pierrec\lz4\v3 (from $GOROOT)
E:\p-tools\go_src\src\github.com\pierrec\lz4\v3 (from $GOPATH)

@gshields gshields added the bug When you are sure about it's a bug label Jul 11, 2020
@ysmood
Copy link
Member

ysmood commented Jul 11, 2020

Don't rush to claim that you have found a bug.

Please learn how Golang module works. There are a lot of articles you can learn from.

@ysmood ysmood added question Questions related to rod and removed bug When you are sure about it's a bug labels Jul 11, 2020
@ysmood ysmood closed this as completed Jul 11, 2020
@gshields
Copy link
Author

gshields commented Jul 12, 2020 via email

@gshields
Copy link
Author

gshields commented Jul 12, 2020 via email

@gshields
Copy link
Author

gshields commented Jul 12, 2020 via email

@ysmood
Copy link
Member

ysmood commented Jul 12, 2020

Do you know how to use google? If you use Google to search your error message cannot find package "github.com/pierrec/lz4/v3", the first couple of results are:

pierrec/lz4#62

and

mholt/archiver#195

The problem is you don't understand how go module works.

Screen Shot 2020-07-12 at 16 02 09

Just set the same flag on windows then use go get:

set GO111MODULE=on
go get github.com/go-rod/rod

@gshields
Copy link
Author

gshields commented Jul 12, 2020 via email

@ysmood
Copy link
Member

ysmood commented Jul 12, 2020

So in reality it is problem with the beta version of GO in a clean

No, it's not. If you try 1.13 or 1.14, they have the same problem. You have to explicitly set GO111MODULE=on.

@gshields
Copy link
Author

gshields commented Jul 12, 2020 via email

@ysmood
Copy link
Member

ysmood commented Jul 12, 2020

Now, you know your description is incorrect. What matters is the go module, not the beta version. If you have set up the go.mod properly, 1.15 beta will work fine.

@ysmood
Copy link
Member

ysmood commented Jul 12, 2020

It's a very common problem for go module. If you google before you ask, we don't have to waste time on this issue.

@go-rod go-rod locked as resolved and limited conversation to collaborators Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Questions related to rod
Projects
None yet
Development

No branches or pull requests

2 participants