send 304 to the user if file not change

go-shiori · Jul 2, 2024 · 7fb2721 · 7fb2721
1 parent a0b01f9
commit 7fb2721
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/internal/http/routes/bookmark.go b/internal/http/routes/bookmark.go
@@ -165,10 +165,19 @@ func (r *BookmarkRoutes) bookmarkThumbnailHandler(c *gin.Context) {
 		return
 	}
 
+	etag := "w/" + model.GetThumbnailPath(bookmark) + "-" + bookmark.ModifiedAt
+
+	// Check if the client's ETag matches the current ETag
+	if c.GetHeader("If-None-Match") == etag {
+		c.Status(http.StatusNotModified)
+		return
+	}
+
 	options := &response.SendFileOptions{
 		Headers: []http.Header{
+			{"Cache-Control": {"no-cache , must-revalidate"}},
 			{"Last-Modified": {bookmark.ModifiedAt}},
-			{"ETag": {"w/" + model.GetThumbnailPath(bookmark) + "-" + bookmark.ModifiedAt}},
+			{"ETag": {etag}},
 		},
 	}