-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: thumbnail should show last thumbnail in server in any condition #858
Open
Monirzadeh
wants to merge
15
commits into
go-shiori:master
Choose a base branch
from
Monirzadeh:fix-thumbnail-cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
202222c
force to not use cache in ui for thumbnail fix #857
Monirzadeh 5100a44
Merge branch 'master' into fix-thumbnail-cache
Monirzadeh 519ad57
Merge branch 'master' into fix-thumbnail-cache
Monirzadeh ce2ce88
Merge branch 'master' into fix-thumbnail-cache
Monirzadeh a15b7f2
Merge branch 'master' into fix-thumbnail-cache
Monirzadeh a7ceb09
Merge branch 'master' into fix-thumbnail-cache
Monirzadeh b49f4b9
Merge branch 'master' into fix-thumbnail-cache
Monirzadeh c91ce2c
use modifiedAt instead of current time
Monirzadeh 78bffff
Merge branch 'master' into fix-thumbnail-cache
Monirzadeh 56a79a4
now can define custom Header for SendFile
Monirzadeh a0b01f9
remvoe use of cacheBuster
Monirzadeh 7fb2721
send 304 to the user if file not change
Monirzadeh 96736ad
Merge branch 'master' into fix-thumbnail-cache
Monirzadeh 861b63f
Merge branch 'master' into fix-thumbnail-cache
Monirzadeh 3e5f39c
back to queryparameter
Monirzadeh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use some properties from the bookmark instead of a random string? This could break the cache unintentially since each time the query string is going to be different. Can we use
?mtime=<bookmark modified time>
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will modified time update if just thumbnail update in article? i am sure that i am not update that in #683 so if that will handle in other part of code automatically we can use modified time too.
i don't find when modified time update in code. do you know where is that or i can send request to update that while thumbnail update
if just thumbnail will update but modify time not update automatically than it will get in trouble in that situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always assumed
Bookmark.ModifiedTime
was the datetime when the bookmark was last modified (attributes/archive/readable/ebook) modified, it seems that is not the case. Let me think and get back to you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up not updating you here.
My idea is:
created
column to the bookmarks with the time the bookmark was first created and prefill it with the currentmodified
for existing bookmarks.modified
every time the bookmark is updated (either the data, content, archive, etc).Then, we can use the
modified
as query parameter for the thumbnail.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is better so i will wait until #876 finish than start working on that.
but an small point: i like the idea of keep first created time and modified time separately if exist instead of prefill (you can look at #848)
so created and modified be better to separated. having created time help me to track my activity in long term so i think having that can be helpful.
@fmartingr and @GreenBlast what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you mention the function that currently update modified time? i can't find that (to use when just thumbnail update).