Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip explicitly ignored fields #85

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

octo
Copy link
Contributor

@octo octo commented Mar 27, 2024

Fixes: #83

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.45%. Comparing base (f16d6ea) to head (4b45766).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   79.06%   79.45%   +0.38%     
==========================================
  Files           3        3              
  Lines         215      219       +4     
==========================================
+ Hits          170      174       +4     
  Misses         32       32              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmzane tmzane changed the title feat: Stop recursion at ignored fields. feat: skip explicitly ignored fields Mar 28, 2024
@tmzane tmzane self-requested a review March 28, 2024 07:46
Copy link
Member

@tmzane tmzane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmzane tmzane merged commit a6b60d7 into go-simpler:main Mar 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for ignored field
2 participants