Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go version in Dockerfile to 1.21.12 #1001

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

ARolek
Copy link
Member

@ARolek ARolek commented Jul 18, 2024

closes #1000

@ARolek ARolek requested a review from gdey July 18, 2024 16:10
@coveralls
Copy link

coveralls commented Jul 18, 2024

Pull Request Test Coverage Report for Build 2b83580ed

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.713%

Totals Coverage Status
Change from base Build f21dd1d7b: 0.0%
Covered Lines: 6551
Relevant Lines: 14024

💛 - Coveralls

@ARolek ARolek force-pushed the issue-1000-bump-go-version branch from 19ed8bd to 338ca5a Compare July 18, 2024 16:26
This upgrade is needed to allow go-sqlite3 to build
with musl 1.2.4+. musl is used a part of the build chain in the
Docker container, which relies on alpine 3.20.
Copy link
Member

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any reason why we did not upgrade to 1.22?

@ARolek
Copy link
Member Author

ARolek commented Jul 18, 2024

any reason why we did not upgrade to 1.22?

I'm planning on doing that in a separate PR.

@ARolek ARolek merged commit ea3020a into master Jul 18, 2024
18 checks passed
@ARolek ARolek deleted the issue-1000-bump-go-version branch July 18, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gospatial/tegola:latest docker image haves security issues
3 participants