Added support for custom string types in ConvertValue.

[dsmontoya]

Description

For some reason reflect.String is not considered in the switch statement. This PR add it to a case so custom string types can be converted.

Checklist

• Code compiles correctly
• Created tests which fail without the change (if possible)
• All tests passing
• Extended the README / documentation, if necessary
• Added myself / the copyright holder to the AUTHORS file

[julienschmidt]

Please add the license header as follows:

// Go MySQL Driver - A MySQL-Driver for Go's database/sql package
//
// Copyright 2017 The Go-MySQL-Driver Authors. All rights reserved.
//
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
// You can obtain one at http://mozilla.org/MPL/2.0/.

package mysql

[julienschmidt]

@dsmontoya this PR requires some changes. Please update your PR when time allows it.

[dsmontoya]

Sorry for the delay. I completely forgot this PR

[julienschmidt]

Looks good to me now.
Let's see why Travis is hanging again...

[julienschmidt]

It seems like Travis somehow managed to not recognize that there is a new commit.
There's also no option to trigger a check or something like that.
I guess the easiest option would be to make another commit, e.g. by rebasing on the current master (or anything else what causes a change to the git history)

[methane]

Maybe, we need to contact to Travis-CI.

[dsmontoya]

Just rebased and pushed a new commit and it's still not working.

[julienschmidt]

@methane where did you find that? I don't see ANY info about this PR on Travis.

[methane]

@julienschmidt https://travis-ci.org/go-sql-driver/mysql/requests

[julienschmidt]

Mailed the Travis support. Let's see....

[julienschmidt]

Reply from the Travis support:

That PR that you mentioned: #623 is coming from an organization called: entropyx. That specific organization is not known to Travis and we do not run PR's coming from unknown organizations.

While this is intended to stop abuse, it does unfortunately cause some issues in situations like these. We are looking into fixing this, as we don't feel that an organization as a whole should have to create a Travis account when working with another that is using Travis CI.

For the time being, a work around would be to have someone in the entropyx organization to create an account in Travis. This should prevent these pull requests from being flagged. If you still encounter issues after that, please don't hesitate to reach out and we'll investigate again.

[dsmontoya]

It's done now.

[julienschmidt]

Thanks! (and sorry for the trouble with Travis)

[dsmontoya]

No problem! And thank you!